[webkit-reviews] review granted: [Bug 77726] Web Inspector: Retained size for classes is too conservative in heap profiler : [Attachment 125296] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted alexeif at chromium.org's
request for review:
Bug 77726: Web Inspector: Retained size for classes is too conservative in heap
profiler
https://bugs.webkit.org/show_bug.cgi?id=77726

Attachment 125296: Patch
https://bugs.webkit.org/attachment.cgi?id=125296&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125296&action=review


> Source/WebCore/inspector/front-end/HeapSnapshot.js:918
> +	   function skip(node)

skip -> shouldSkip?

> Source/WebCore/inspector/front-end/HeapSnapshot.js:951
> +	   var snapshot = this;

Just pass it as a parameter to forDominatedNodes.

> Source/WebCore/inspector/front-end/HeapSnapshot.js:961
> +	       var doms = snapshot._dominatedNodesOfNode(node);

doms -> dominatedNodeIndexes, we usually avoid abbreviations in the front-end
code