[webkit-reviews] review requested: [Bug 54623] RTL web content should have left-hand scrollbar. : [Attachment 125303] Patch v10 (Applied comments)

[bugzilla-daemon at webkit.org]

Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 54623: RTL web content should have left-hand scrollbar.
https://bugs.webkit.org/show_bug.cgi?id=54623

Attachment 125303: Patch v10 (Applied comments)
https://bugs.webkit.org/attachment.cgi?id=125303&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings Niwa-san,

Many thanks for your comments.

(In reply to comment #47)
> Sorry, that comment seems bogus. What I really meant is move "if
(positionedObject->style()->position() != FixedPosition)" outside of if-defs to
be shared. Then, you only need to wrap two lines inside if-defs (x -=
verticalScrollbarWidth(); and if before that).

Done. Thanks for your correction.

> Hm... how about shouldPlaceBlockDirectionScrollbarOnLogicalLeft() then ?

Done. I should have describe this issue when I noticed it.

Regards,

Hironori Bono