[webkit-reviews] review denied: [Bug 77096] Web Inspector: [Meta] Allow emulation of touch events : [Attachment 125299] [PATCH] Rebased

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 3 03:04:48 PST 2012


Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 77096: Web Inspector: [Meta] Allow emulation of touch events
https://bugs.webkit.org/show_bug.cgi?id=77096

Attachment 125299: [PATCH] Rebased
https://bugs.webkit.org/attachment.cgi?id=125299&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125299&action=review


> Source/WebCore/inspector/Inspector.json:1517
> +		   "description": "Toggles mouse event-based touch event
emulation."

"hidden" :true

> Source/WebCore/inspector/InspectorDOMAgent.cpp:412
> +	   documents.at(i)->settings()->setTouchEventEmulationEnabled(enabled);


What about the documents that are added / removed from the list dynamically?
You should also adjust their settings.

> Source/WebCore/inspector/front-end/Settings.js:48
> +    emulateTouchEvents: false

I don't think you need this change.

> Source/WebCore/inspector/front-end/SettingsScreen.js:45
> +	  
p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Emulate touch
events"), WebInspector.settings.emulateTouchEvents));

This should not be under the showDockToRight.


More information about the webkit-reviews mailing list