[webkit-reviews] review granted: [Bug 77620] Hovered node gets stuck on touch events : [Attachment 125295] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Allan Sandfeld
Jensen <allan.jensen at nokia.com>'s request for review:
Bug 77620: Hovered node gets stuck on touch events
https://bugs.webkit.org/show_bug.cgi?id=77620

Attachment 125295: Patch
https://bugs.webkit.org/attachment.cgi?id=125295&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125295&action=review


> Source/WebCore/ChangeLog:10
> +
> +	   * page/EventHandler.cpp:
> +	   (WebCore::eventNameForTouchPointState): Explicitly show how
TouchStationary is handled.
> +	   (WebCore::EventHandler::handleTouchEvent): Remove TouchStationary
from ASSERT.
> +

Maybe you could write that you are adding code so that it is like before you
last patch?

> Source/WebCore/page/EventHandler.cpp:3200
> +    case PlatformTouchPoint::TouchStationary:
> +	   // TouchStationary state is not converted to touch events.
>      default:
>	   ASSERT_NOT_REACHED();

It could be a bit more obvious that the ASSERT is also meant for the
TouchStationary