[webkit-reviews] review requested: [Bug 77525] SelectorChecker::checkSelector: move parameters into a struct : [Attachment 125283] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 3 01:04:46 PST 2012


Roland Steiner <rolandsteiner at chromium.org> has asked  for review:
Bug 77525: SelectorChecker::checkSelector: move parameters into a struct
https://bugs.webkit.org/show_bug.cgi?id=77525

Attachment 125283: Patch
https://bugs.webkit.org/attachment.cgi?id=125283&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at chromium.org>
Patch comments: Passing the struct SelectorCheckingContext by value in
checkSelector: this corresponds to the previous parameter-passing and the
internals are also modified rather heavily. In comparison, I pass them by const
reference to checkOneSelector, because only :not and :-webkit-any need to
modify anything.


More information about the webkit-reviews mailing list