[webkit-reviews] review granted: [Bug 77105] Implement touch event emulation in the WebCore layer : [Attachment 124928] [PATCH] more comments addressed

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 77105: Implement touch event emulation in the WebCore layer
https://bugs.webkit.org/show_bug.cgi?id=77105

Attachment 124928: [PATCH] more comments addressed
https://bugs.webkit.org/attachment.cgi?id=124928&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124928&action=review


Seems okay. We can always improve it iteratively since it's not a Web-facing
API. But please make sure adding new methods to internals.settings doesn't
break any builds when you land it.

> Source/WebCore/testing/InternalSettings.cpp:274
> +void InternalSettings::setTouchEventEmulationEnabled(bool enabled,
ExceptionCode& ec)

Don't you need to add symbols for this?