[webkit-reviews] review granted: [Bug 77612] Stop calling Element::ensureShadowRoot in Internals. : [Attachment 125251] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 77612: Stop calling Element::ensureShadowRoot in Internals.
https://bugs.webkit.org/show_bug.cgi?id=77612

Attachment 125251: Patch
https://bugs.webkit.org/attachment.cgi?id=125251&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125251&action=review


> Source/WebCore/ChangeLog:8
> +	   Instead of ensureShadowRoot, we check the existence of shadow root
and create one if there is not.

Could you explain why we need this change?

> Source/WebCore/testing/Internals.cpp:199
> +    return ShadowRoot::create(host, ec).get();

This is actually safe. But its safety isn't obvious at a glance. 
Could you change the return type to RefPtr, to make this clearly safe?