[webkit-reviews] review granted: [Bug 77586] [EFL] Add contentsSize flag into ewk_tiled_backing_store's private data. : [Attachment 125239] Patch updated.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 2 20:00:30 PST 2012


Andreas Kling <kling at webkit.org> has granted KwangHyuk
<hyuki.kim at samsung.com>'s request for review:
Bug 77586: [EFL] Add contentsSize flag into ewk_tiled_backing_store's private
data.
https://bugs.webkit.org/show_bug.cgi?id=77586

Attachment 125239: Patch updated.
https://bugs.webkit.org/attachment.cgi?id=125239&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125239&action=review


r=me

> Source/WebKit/efl/ChangeLog:9
> +	   ewk_tiled_bakcing_store can not detect the conflict between them.

Typo, ewk_tiled_backing_store.

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1377
> +	   if (priv->changed.contentsSize)
> +	       priv->changed.contentsSize = false;

No need for the "if" here, you could just do priv->changed.contentsSize =
false; unconditionally.


More information about the webkit-reviews mailing list