[webkit-reviews] review granted: [Bug 77295] V8 idl code generator doesn't handle [CachedAttribute] on SerializedScriptValue attributes. : [Attachment 124611] Better patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 77295: V8 idl code generator doesn't handle [CachedAttribute] on
SerializedScriptValue attributes.
https://bugs.webkit.org/show_bug.cgi?id=77295

Attachment 124611: Better patch
https://bugs.webkit.org/attachment.cgi?id=124611&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124611&action=review


Feel free to ping me if I am missing a review.

>>>
Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cp
p:88
>>> +	
info.Holder()->DeleteHiddenValue(v8::String::NewSymbol("cachedValue")); //
Invalidate the cached value.
>> 
>> Why don't you set the new value by SetHiddenValue(), instead of invalidating
the current value?
> 
> We'd need to deserialize it, i figured it would be better to do that lazily
when it's requested (i think the JSC generator does it like this as well).
Also, (using this case as an example) we'd need to assume that v ==
imp->getCachedValue(), otherwise we'd need to call imp->getCachedValue() before
deserializing, and by that point we might as well just let the getter do its
job.

Makes sense!