[webkit-reviews] review denied: [Bug 62107] Filename in file upload should not URL-encode " to %22 : [Attachment 111915] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Daniel Cheng
<dcheng at chromium.org>'s request for review:
Bug 62107: Filename in file upload should not URL-encode " to %22
https://bugs.webkit.org/show_bug.cgi?id=62107

Attachment 111915: Patch
https://bugs.webkit.org/attachment.cgi?id=111915&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I don't think that this is safe. IE and Firefox don't escape backslashes
because these are normal in Windows paths. We don't have much indication that
servers actually treat backslashes as escape characters (see
<http://java.net/jira/browse/JERSEY-759> about a server that does, and its
users see it as broken as a result).

If we use backslash to escape, servers expecting IE behavior will treat those
as path separators.

I agree that the current situation is not good. Unfortunately, there doesn't
seem to be much that could be done in WebKit unilaterally. I suggest working
with WHATWG or HTML WG to get something specified in HTML5, and getting
browsers converge on that.