[webkit-reviews] review denied: [Bug 77677] Implement current executable path finding for win32 : [Attachment 125173] Implement current executable path finding for win32
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 2 13:29:34 PST 2012
Martin Robinson <mrobinson at webkit.org> has denied Kalev Lember
<kalevlember at gmail.com>'s request for review:
Bug 77677: Implement current executable path finding for win32
https://bugs.webkit.org/show_bug.cgi?id=77677
Attachment 125173: Implement current executable path finding for win32
https://bugs.webkit.org/attachment.cgi?id=125173&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125173&action=review
r- only because you are not a committer and cannot fix the style nit before
landing.
>> Source/JavaScriptCore/wtf/gobject/GlibUtilities.cpp:25
>> +#if OS(WINDOWS)
>> +#include <wtf/text/WTFString.h>
>> +#include <windows.h>
>
> Alphabetical sorting problem. [build/include_order] [4]
Please fix this simple style nit.
More information about the webkit-reviews
mailing list