[webkit-reviews] review granted: [Bug 69210] CSS 2.1 failure: inline-box-002.htm fails : [Attachment 124829] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 69210: CSS 2.1 failure: inline-box-002.htm fails
https://bugs.webkit.org/show_bug.cgi?id=69210

Attachment 124829: Patch
https://bugs.webkit.org/attachment.cgi?id=124829&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124829&action=review


r=me

> Source/WebCore/rendering/RenderObject.cpp:1952
> +	   if (toRenderBlock(child)->isAnonymousBlockContinuation())
> +	       newStyle->setPosition(child->style()->position());

I think this would read more cleanly as:

if (child->isRelPositioned() &&
toRenderBlock(child)->isAnonymousBlockContinuation())
    newStyle->setPosition(RelativePosition);

If the child already wasn't relatively positioned (the common case), then you
don't need to mutate newStyle, since it won't be relatively positioned either.