[webkit-reviews] review requested: [Bug 58837] Fieldset disabled attribute does not work : [Attachment 125164] patch for review / feedback.

[bugzilla-daemon at webkit.org]

Zeno Albisser <zeno at webkit.org> has asked  for review:
Bug 58837: Fieldset disabled attribute does not work
https://bugs.webkit.org/show_bug.cgi?id=58837

Attachment 125164: patch for review / feedback.
https://bugs.webkit.org/attachment.cgi?id=125164&action=review

------- Additional Comments from Zeno Albisser <zeno at webkit.org>
I changed the implementation to register FormControlElements to ancestor
FieldSetElements if available.
So instead of traversing the whole FieldSet subtree after a change we can now
simply register FormControlElements once and update them directly on a change.
With the provided unit test i could not measure any significant performance
impact.
But of course this implementation has it's weak spots as well. For example,
when we have many (hundreds) of edges between a FormControlElement and its
FieldSet ancestor, and this constellation many times again.

Any thoughts/comments?