[webkit-reviews] review granted: [Bug 77657] NPAPI will not send mouse up events when mouse is outside plugin area : [Attachment 125152] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 77657: NPAPI will not send mouse up events when mouse is outside plugin
area
https://bugs.webkit.org/show_bug.cgi?id=77657

Attachment 125152: Patch
https://bugs.webkit.org/attachment.cgi?id=125152&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125152&action=review


r=me

> Source/WebCore/ChangeLog:9
> +	   Export EventHandler::setCapturingMouseEvents.

Typo, setCapturingMouseEventsNode.

> Source/WebKit2/ChangeLog:9
> +	   Use EventHandler::setCapturingMouseEvents to ensure we get all the
mouse events when the mouse is down.

Ditto.

> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:637
> +	   if (currentEvent->type() == WebEvent::MouseDown) {
>	       focusPluginElement();
> +	      
frame()->eventHandler()->setCapturingMouseEventsNode(m_pluginElement.get());
> +	   else if (currentEvent->type() == WebEvent::MouseUp)

}}}}}}}}}}}}}}}}}}}}}