[webkit-reviews] review granted: [Bug 77621] Move remaining implementation from CSSStyleDeclaration to subclasses : [Attachment 125112] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 2 09:54:58 PST 2012


Andreas Kling <kling at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 77621: Move remaining implementation from CSSStyleDeclaration to subclasses
https://bugs.webkit.org/show_bug.cgi?id=77621

Attachment 125112: patch
https://bugs.webkit.org/attachment.cgi?id=125112&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125112&action=review


> Source/WebCore/css/CSSMutableStyleDeclaration.h:129
>      // CSSOM functions. Don't make these public.
> +    virtual CSSRule* parentRule() const;

We should decorate the subclasses with OVERRIDE as appropriate.


More information about the webkit-reviews mailing list