[webkit-reviews] review granted: [Bug 77308] [EFL] Enable WebGL with glx backend : [Attachment 124747] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted ChangSeok Oh
<kevin.cs.oh at gmail.com>'s request for review:
Bug 77308: [EFL] Enable WebGL with glx backend
https://bugs.webkit.org/show_bug.cgi?id=77308

Attachment 124747: Patch
https://bugs.webkit.org/attachment.cgi?id=124747&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124747&action=review


Just a couple tiny style nits. Please fix them before landing the patch.

> Source/WebCore/platform/graphics/efl/DrawingBufferEfl.cpp:40
> +DrawingBuffer::DrawingBuffer(GraphicsContext3D* context,
> +				const IntSize& size,
> +				bool multisampleExtensionSupported,
> +				bool packedDepthStencilExtensionSupported,
> +				bool separateBackingTexture)

In WebKit we usually keep parameter lists on one line.

> Source/WebCore/platform/graphics/efl/DrawingBufferEfl.cpp:66
> +    // create a texture to render into

This comment should start with a capital letter and end with a period.