[webkit-reviews] review requested: [Bug 61558] iframe with scrolling=no incorrectly autoscrollable : [Attachment 125103] Patch to fix scrolling of frame content with "scrolling=no", after incorporating review comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 2 02:20:34 PST 2012


Swapna <spottabathini at innominds.com> has asked	for review:
Bug 61558: iframe with scrolling=no incorrectly autoscrollable
https://bugs.webkit.org/show_bug.cgi?id=61558

Attachment 125103: Patch to fix scrolling of frame content with "scrolling=no",
after incorporating review comments.
https://bugs.webkit.org/attachment.cgi?id=125103&action=review

------- Additional Comments from Swapna <spottabathini at innominds.com>
Patch after incorporating review comments.

Hi Antonio,
> any alternativa way of fixing this would be making
canBeProgramaticallyScrolled also take case of this check.
The attribute "scrolling" is specific to iframe & frame. Hence this needs to be
handled along with iframe/frame scrolling logic. 
More over, we can differentiate mainframe & frame element using ownerElement
only. And it may not be correct to access ownerelement in 
canBeProgramaticallyScrolled().


More information about the webkit-reviews mailing list