[webkit-reviews] review granted: [Bug 77611] Rename [ConvertUndefinedOrNullToNullString] to [TreatNullAs=EmptyString, TreatUndefinedAs=EmptyString] : [Attachment 125084] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 77611: Rename [ConvertUndefinedOrNullToNullString] to
[TreatNullAs=EmptyString, TreatUndefinedAs=EmptyString]
https://bugs.webkit.org/show_bug.cgi?id=77611

Attachment 125084: Patch
https://bugs.webkit.org/attachment.cgi?id=125084&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125084&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2875
> +	   }
> +	   if (($signature->extendedAttributes->{"TreatNullAs"} and
$signature->extendedAttributes->{"TreatNullAs"} eq "EmptyString") or
$signature->extendedAttributes->{"Reflect"}) {

Do we need an "else" here?

> Source/WebCore/bindings/scripts/test/TestObj.idl:195
> -	   void convert5(in [ConvertUndefinedOrNullToNullString] e);
> +	   void convert5(in [TreatNullAs=EmptyString,
TreatUndefinedAs=EmptyString] e);

In WebKit, the null string is different from the empty string.	Are you sure
this is right?