[webkit-reviews] review granted: [Bug 77596] update CSS3 calc() color tests to use pre/post js : [Attachment 125067] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Mike Lawther
<mikelawther at chromium.org>'s request for review:
Bug 77596: update CSS3 calc() color tests to use pre/post js
https://bugs.webkit.org/show_bug.cgi?id=77596

Attachment 125067: Patch
https://bugs.webkit.org/attachment.cgi?id=125067&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125067&action=review


> LayoutTests/css3/calc/color-hsl.html:5
> -#simple	  {color:
hsl(-webkit-calc(120),-webkit-calc(75%),-webkit-calc(50%));}
> +    #controlsimple { color: hsl(120,75%,50%); }
> +    #simple	      { color:
hsl(-webkit-calcy(120),-webkit-calc(75%),-webkit-calc(50%)); }

I don't like adding indentation to the top-level code.

> LayoutTests/css3/calc/color-hsl.html:21
>  <script>
> -if (window.layoutTestController)
> -    layoutTestController.dumpAsText();
> -
> -tests = ["simple", "alpha"];
> +    description("Tests that CSS3 calc() can be used with the hsl() and
hsla() functions");
> +    
> +    tests = ["simple", "alpha"];

ditto.

> LayoutTests/css3/calc/color-rgb.html:4
> +    #controlsimple { color: rgb(10,180,30); }

ditto.

> LayoutTests/css3/calc/color-rgb.html:29
> +    description("Tests that CSS3 calc() can be used with the rgb() and
rgba() functions");

ditto.