[webkit-reviews] review denied: [Bug 77155] [chromium] GL_CHROMIUM_gpu_memory_manager : [Attachment 125023] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Michal Mocny
<mmocny at chromium.org>'s request for review:
Bug 77155: [chromium] GL_CHROMIUM_gpu_memory_manager
https://bugs.webkit.org/show_bug.cgi?id=77155

Attachment 125023: Patch
https://bugs.webkit.org/attachment.cgi?id=125023&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125023&action=review


Can you put a description somewhere of what this does?

> Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h:97
> +    virtual void addAffectedWebViewCHROMIUM(WebKit::WebView* webview);
> +    virtual void removeAffectedWebViewCHROMIUM(WebKit::WebView* webview);

you can't talk about namespace WebKit concepts in WebCore, it's a layering
violation.

> Source/WebKit/chromium/public/platform/WebGpuMemoryAllocation.h:2
> + * Copyright (C) 2009 Google Inc. All rights reserved.

2012

> Source/WebKit/chromium/public/platform/WebGpuMemoryAllocation.h:8
> + *	  * Redistributions of source code must retain the above copyright

we use 2-clause license header for new files

> Source/WebKit/chromium/public/platform/WebGpuMemoryAllocation.h:37
> +#include <content/common/gpu/gpu_memory_allocation.h>

this is also a layering violation. WebKit should not depend on content