[webkit-reviews] review granted: [Bug 71262] Web Inspector: Add colorpicker functionality to color swatches in Styles Sidebar : [Attachment 125058] Add colorpicker functionality to color swatches in Styles Sidebar - Using native popover and keeping original color format
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 1 18:17:52 PST 2012
Brian Grinstead <briangrinstead at gmail.com> has granted review:
Bug 71262: Web Inspector: Add colorpicker functionality to color swatches in
Styles Sidebar
https://bugs.webkit.org/show_bug.cgi?id=71262
Attachment 125058: Add colorpicker functionality to color swatches in Styles
Sidebar - Using native popover and keeping original color format
https://bugs.webkit.org/attachment.cgi?id=125058&action=review
------- Additional Comments from Brian Grinstead <briangrinstead at gmail.com>
Reverted popover changes, incorporating other feedback from comments.
Should now be keeping the initial color format when possible. NOTE: I know
when you alt+click to switch formats it works while dragging but reverts back
to the old format when finished. I can't figure out exactly why this is
happening (something to do with a major applyStyleText). I went ahead and sent
it through even with this issue b/c it is relatively minor and just to keep the
dialog going (since there seems to be UI feedback still coming through).
More information about the webkit-reviews
mailing list