[webkit-reviews] review granted: [Bug 77580] Support targetOrigin = "/" in postMessage for sending messages to same origin as source document : [Attachment 125031] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 1 16:54:59 PST 2012


Adam Barth <abarth at webkit.org> has granted Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 77580: Support targetOrigin = "/" in postMessage for sending messages to
same origin as source document
https://bugs.webkit.org/show_bug.cgi?id=77580

Attachment 125031: Patch
https://bugs.webkit.org/attachment.cgi?id=125031&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125031&action=review


Thanks!

> Source/WebCore/page/DOMWindow.cpp:836
> +	   if (!sourceDocument)
> +	       return;

I wonder if we shouldn't just return right away when !sourceDocument.  I can
understand why you've chosen this path though.


More information about the webkit-reviews mailing list