[webkit-reviews] review granted: [Bug 74121] Consider user's preferred language when choosing text tracks : [Attachment 125015] Proposed patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 74121: Consider user's preferred language when choosing text tracks
https://bugs.webkit.org/show_bug.cgi?id=74121

Attachment 125015: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=125015&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125015&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:2365
> +	       // ...

?

> Source/WebCore/platform/Language.cpp:93
> +    if (lowercaseLanguageCode.length() >= 3 && lowercaseLanguageCode[2] ==
'_')
> +	   lowercaseLanguageCode.replace(2, 1, "-");

Don't we want to use CoreFoundation to canonicalize? AppleLanguages can
contains things like "English" on some systems.