[webkit-reviews] review granted: [Bug 77505] Paginated display does not respect page-break-{before, after} : [Attachment 124967] Make RenderView pagination respect page-break properties by default and add API to make it respect column-break properties instead

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 77505: Paginated display does not respect page-break-{before,after}
https://bugs.webkit.org/show_bug.cgi?id=77505

Attachment 124967: Make RenderView pagination respect page-break properties by
default and add API to make it respect column-break properties instead
https://bugs.webkit.org/attachment.cgi?id=124967&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124967&action=review


> Source/WebCore/rendering/RenderBlock.h:908
> +    virtual ColumnInfo::PaginationUnit paginationUnit();

Make this member function const?

> Source/WebCore/rendering/RenderView.cpp:209
> +    if (m_frameView) {
> +	   if (Frame* frame = m_frameView->frame()) {
> +	       if (Page* page = frame->page())
> +		   return (frame == page->mainFrame() &&
page->pagination().behavesLikeColumns) ? ColumnInfo::Column : ColumnInfo::Page;

> +	   }
> +    }

I think it would be nice to have a helper for the “page if this is the main
frame of a page” logic. It’s repeated a few different places and it would be
nice if it wasn’t.