[webkit-reviews] review granted: [Bug 77488] Replace JSArray destructor with finalizer : [Attachment 125001] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 1 13:45:50 PST 2012


Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 77488: Replace JSArray destructor with finalizer
https://bugs.webkit.org/show_bug.cgi?id=77488

Attachment 125001: Patch
https://bugs.webkit.org/attachment.cgi?id=125001&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125001&action=review


r=me

> Source/JavaScriptCore/runtime/JSArray.cpp:203
> +void JSArray::finalize(JSCell* cell)

Please add a comment here noting that this function can be called more than
once, so a future developer doesn't add unsafe code.


More information about the webkit-reviews mailing list