[webkit-reviews] review requested: [Bug 76732] [Chromium] Enable deferred canvas rendering in the skia port : [Attachment 124995] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 1 12:57:06 PST 2012
Stephen White <senorblanco at chromium.org> has asked for review:
Bug 76732: [Chromium] Enable deferred canvas rendering in the skia port
https://bugs.webkit.org/show_bug.cgi?id=76732
Attachment 124995: Patch
https://bugs.webkit.org/attachment.cgi?id=124995&action=review
------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124995&action=review
> Source/WebCore/html/HTMLCanvasElement.cpp:485
> + RenderingMode renderingMode = shouldAccelerate(bufferSize) ? Accelerated
: UnacceleratedNonPlatformBuffer;
I think this one should still be wrapped in an #if USE(SKIA) (unless other
ports map UnacceleratedNonPlatformBuffer to Unaccelerated).
> Source/WebCore/platform/graphics/chromium/Canvas2DLayerChromium.cpp:64
> + , m_canvas(0)
This isn't wrapped in #if USE(SKIA), but the declaration is. It's your call,
but at this point I'd probably just remove #if USE(SKIA) everywhere in this
file and in the header. I don't think this class is much use without Skia
anymore.
More information about the webkit-reviews
mailing list