[webkit-reviews] review denied: [Bug 77466] [Qt][WK2] run-webkit-tests --qt crashes if WEBKIT_TESTFONTS is not set : [Attachment 124987] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Jesus Sanchez-Palencia
<jesus at webkit.org>'s request for review:
Bug 77466: [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not
set
https://bugs.webkit.org/show_bug.cgi?id=77466

Attachment 124987: Patch
https://bugs.webkit.org/attachment.cgi?id=124987&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124987&action=review


> Tools/Scripts/webkitpy/layout_tests/port/qt.py:140
> +	   if not 'WEBKIT_TESTFONTS' in os.environ:
> +	       print "\n\nThe WEBKIT_TESTFONTS environment variable is not
defined or not set properly"
> +	       print "You must set it before running the tests."
> +	       print "Use git to grab the actual fonts from
http://gitorious.org/qtwebkit/testfonts\n"
> +	       raise RuntimeError('WEBKIT_TESTFONTS not set')

You should add tests that show that this exception is/isn't thrown in the
appropriate cases.

> Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py:86
> +	   try:
> +	       port = self.make_port()
> +	       env = port.setup_environ_for_server(port.driver_name())
> +	       self.assertEquals(env['QTWEBKIT_PLUGIN_PATH'], 'MOCK output of
child process/lib/plugins')
> +	   except RuntimeError, e:
> +	       print e

I don't think we want to add extra output to test-webkitpy. The test should set
things up so that the exception doesn't get thrown.