[webkit-reviews] review granted: [Bug 49058] CSSStyleDeclaration.getPropertyPriority() fails for CSS shorthand properties with 'important' priority : [Attachment 124978] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 49058: CSSStyleDeclaration.getPropertyPriority() fails for CSS shorthand
properties with 'important' priority
https://bugs.webkit.org/show_bug.cgi?id=49058

Attachment 124978: Patch
https://bugs.webkit.org/attachment.cgi?id=124978&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124978&action=review


> Source/WebKit/qt/ChangeLog:8
> +	   Update the code as getPropertyPriority has been renamed to
hasPropertyImportantPriority.

hasPropertyImportantPriority -> propertyIsImportant

> Source/WebCore/css/CSSMutableStyleDeclaration.cpp:663
> +    for (size_t i = 0; i < longhands.length(); ++i) {

longhands.length() returns unsigned so 'i' should be unsigned as well.

> Source/WebCore/css/CSSMutableStyleDeclaration.cpp:680
> +    return containsOnlyImportantProperties(longhands);

I think we can fold containsOnlyImportantProperties() into the
propertyIsImportant() here, no need for it to be a separate function.

> LayoutTests/fast/css/shorthand-priority.html:10
> +description("Tests that query the priority for a shorthand works.");

query -> querying