[webkit-reviews] review granted: [Bug 77383] Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with : [Attachment 124973] New patch that addresses most of Sam's comments

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Beth Dakin <bdakin at apple.com>'s request
for review:
Bug 77383: Add a different didFirstVisuallNonEmptyLayout heuristic to
experiment with
https://bugs.webkit.org/show_bug.cgi?id=77383

Attachment 124973: New patch that addresses most of Sam's comments
https://bugs.webkit.org/attachment.cgi?id=124973&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124973&action=review


This still needs tests, and I would like a follow up that rationalizes that we
don't want to track layouts (first, firstVisuallyNonEmpty,
firstNewFirstVisuallyNonEmpty) at the frame level anymore, and therefore should
not have a frame in their API.

> Source/WebCore/page/Page.h:358
> +	   void setPaintedObjectsCounterThreshold(uint64_t threshold);
> +	   void startCountingRepaintedObjects();

Should these mention the word "relevant"?

> Source/WebCore/page/Page.h:479
> +	   bool m_isCountingRepaintedObjects;

Should this mention the word "relevant"?

> Source/WebKit2/UIProcess/API/C/WKPage.h:111
> +    WKPageDidNewFirstVisuallyNonEmptyLayoutCallback			  
didNewFirstVisuallyNonEmptyLayout;

Please put a comment here about merging this with FirstVisuallyNonEmptyLayout.