[webkit-reviews] review denied: [Bug 76445] [Qt] build-webkit does not detect the number of CPUs : [Attachment 124954] proposed patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied János Badics
<dicska at gmail.com>'s request for review:
Bug 76445: [Qt] build-webkit does not detect the number of CPUs
https://bugs.webkit.org/show_bug.cgi?id=76445

Attachment 124954: proposed patch
https://bugs.webkit.org/attachment.cgi?id=124954&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124954&action=review


good stuff, a few comments:

> Tools/Scripts/webkitdirs.pm:2089
> +    if ($makeargs !~ /-j/i && (!defined $ENV{"MAKEFLAGS"} ||
($ENV{"MAKEFLAGS"} !~ /-j/i ))){

Slight style (missing space before {), and the regex will trigger on stuff like
--just-print as well. build-webkit uses -j\s*\d+