[webkit-reviews] review granted: [Bug 76815] [GTK] editing/inserting/4960120-2.html flaky crash : [Attachment 124944] Patch proposal + unskip tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 1 08:36:44 PST 2012


Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 76815: [GTK] editing/inserting/4960120-2.html flaky crash
https://bugs.webkit.org/show_bug.cgi?id=76815

Attachment 124944: Patch proposal + unskip tests
https://bugs.webkit.org/attachment.cgi?id=124944&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124944&action=review


> Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:1040
> +    // We can't do anything else if we reach this point.
> +    if (!startNode)
> +	   return 0;

It might be good to explain in the comment why startNode is null here.


More information about the webkit-reviews mailing list