[webkit-reviews] review granted: [Bug 77067] Parenthesis in RTL fonts are not mirrored with SVG fonts : [Attachment 124563] Update glyph-selection-arabic-forms.svg to only use Khan character in the hopes that EWS Linux will pass

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Philip Rogers
<pdr at google.com>'s request for review:
Bug 77067: Parenthesis in RTL fonts are not mirrored with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=77067

Attachment 124563: Update glyph-selection-arabic-forms.svg to only use Khan
character in the hopes that EWS Linux will pass
https://bugs.webkit.org/attachment.cgi?id=124563&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124563&action=review


Patch looks great, r=me with a few comments:

> Source/WebCore/svg/SVGFontData.cpp:277
> +    for (unsigned i = 0; i < length; ) {

I would have used a while loop for this. No blocker.

> LayoutTests/ChangeLog:11
> +	   which handles mirroring the characters when rendering selecting
glyphs
> +	   for SVG fonts. I also made a small cosmetic change in the function

s/rendering// ? I'm not sure what you mean otherwise.
The ChangeLog should be fixed at least before landing.