[webkit-reviews] review denied: [Bug 77520] [WK2] Modify parameters of willSubmitForm callback : [Attachment 124902] proposed patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Grzegorz <g.czajkowski at samsung.com>'s
request for review:
Bug 77520: [WK2] Modify parameters of willSubmitForm callback
https://bugs.webkit.org/show_bug.cgi?id=77520

Attachment 124902: proposed patch
https://bugs.webkit.org/attachment.cgi?id=124902&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124902&action=review


This patch doesn't have any tests.

> Source/WebCore/loader/FormState.cpp:40
> +static String currentValueKey = "currentValue";

This creates a static initializer and will break the AppleMac build.

> Source/WebCore/loader/FormState.cpp:55
> +const Vector<HashMap<String, String> > FormState::textFieldsPropertis()
const

Why are you returning const here?  textFieldsPropertis is misspelled.

> Source/WebCore/loader/FormState.cpp:58
> +    for (size_t i = 0; i < m_form->associatedElements().size(); ++i) {

Is calling associatedElements() expensive?