[webkit-reviews] review denied: [Bug 76262] StyleRecalc should occur when shadow root exists and light children are changed. : [Attachment 124891] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 1 01:35:05 PST 2012
MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 76262: StyleRecalc should occur when shadow root exists and light children
are changed.
https://bugs.webkit.org/show_bug.cgi?id=76262
Attachment 124891: Patch
https://bugs.webkit.org/attachment.cgi?id=124891&action=review
------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124891&action=review
> Source/WebCore/ChangeLog:8
> + Set style recalculation flag when a child element is changed.
Could you elaborate why we need this change?
> Source/WebCore/dom/Element.cpp:1371
> + setNeedsStyleRecalc();
This could be shadowRoot->hostChildrenChanged().
More information about the webkit-reviews
mailing list