[webkit-reviews] review requested: [Bug 73192] <style scoped>: implement scoped selector matching : [Attachment 124899] patch, updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 1 01:05:16 PST 2012


Roland Steiner <rolandsteiner at chromium.org> has asked  for review:
Bug 73192: <style scoped>: implement scoped selector matching
https://bugs.webkit.org/show_bug.cgi?id=73192

Attachment 124899: patch, updated
https://bugs.webkit.org/attachment.cgi?id=124899&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at chromium.org>
Updated patch after landing basic <style scoped> implementation. Remarks: I'm
storing the scope to use in member variables in order to reduce the amount of
paramter passing and #ifdef-ing. I'm not sure if I should go further and do
this for fastCheckSingleSelector as well (although this would require making
that template function a class member) or, conversely, whether it's a good idea
in the first place.


More information about the webkit-reviews mailing list