[webkit-reviews] review requested: [Bug 77517] Visual Studio 2010 toolchain support : [Attachment 124896] VS2010 support scripts

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 1 00:32:41 PST 2012


Ashod Nakashian <ashodnakashian at yahoo.com> has asked  for review:
Bug 77517: Visual Studio 2010 toolchain support
https://bugs.webkit.org/show_bug.cgi?id=77517

Attachment 124896: VS2010 support scripts
https://bugs.webkit.org/attachment.cgi?id=124896&action=review

------- Additional Comments from Ashod Nakashian <ashodnakashian at yahoo.com>
Currently VS2005 and VS2008 are recognized and supported by pdevenv script.
There is growing need to add support for VS2010 toolchain. Supporting VS2010
will help some of us fix compiler issues related to the newer compiler and
accelerate the eventual transition to using VS2010 primarily. This need to
transition to VS2010 is heightened by the fact that VS2005 lacks support on
Windows 7, which is increasingly becoming dominant.

In recognition to the need to support VS2005 for the foreseeable future, and
the maintenance overhead associated with supporting two sets of project and
property-sheet files (due to VS2010's departure from the old format used by
VCBuild and earlier VS versions,) an effort must be made to support only the
mainline set of files. Currently the mainline is VS2005 and we should keep
supporting it until it's completely phased out (back-porting the files is a
much harder task than going in the other direction.)

Besides the maintenance issues pointed out, the main hurdle to supporting
VS2010 is the compiler errors. It turns out this may be (temporarily)
circumvented as the errors are actually due to warnings. See bug #34804.

I've spent some time and have successfully built WebKit WinCairo on Windows 7.
The resulting binaries are fully functional, although I didn't run the test
suite yet. I also plan to build the CoreGraphics version in the coming days,
hopefully no surprises there either.

I've written about the experience of porting WebKit to VS2010 (on Windows 7)
and issues I came across and how I solved them on my personal blog:
http://blog.ashodnakashian.com/2012/01/building-webkit-on-windows-7-with-vs2010


My port fully honors the requirements to support VS2005 and to avoid adding a
second set of project and property-sheet files by first automatically upgrading
the solution/project files using VS2010, which generates new files leaving old
ones intact. In addition, all changes necessary to fix build errors automated
and are completely transparent.

I limited my patch to exactly one file: pdevenv. I've also added a new Windows
batch file only for convenience, but it's completely optional and may be left
out (although I strongly recommend committing it.) The batch file in question
mounts the source directory, sets up the environment and launches CygWin. The
modified script, pdevenv, only adds support to VS2010 and, via perlre, fixes
some of the files to get a clean build.

I've taken the liberty to attach the two files for review. I believe this
approach is the least intrusive/disruptive and does give the community full
VS2010 support. I await comments and criticism.


More information about the webkit-reviews mailing list