[webkit-reviews] review granted: [Bug 103539] seamless iframes don't inherit styles when srcdoc is used : [Attachment 180976] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 31 07:47:53 PST 2012
Eric Seidel <eric at webkit.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 103539: seamless iframes don't inherit styles when srcdoc is used
https://bugs.webkit.org/show_bug.cgi?id=103539
Attachment 180976: Patch
https://bugs.webkit.org/attachment.cgi?id=180976&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180976&action=review
> Source/WebCore/dom/Document.cpp:4388
> + if (shouldDisplaySeamlesslyWithParent())
> + styleResolverChanged(DeferRecalcStyle);
I might add a comment here which says something like:
// Seamless iframes will need a StyleResolver recalc to inherit styles from
their parent even
// if they don't have any styling of their own (which would normally trigger
this recalc).
More information about the webkit-reviews
mailing list