[webkit-reviews] review granted: [Bug 105863] Move pointer to Document up from SelectorChecker to StyleResolver. : [Attachment 180945] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Dec 29 14:39:11 PST 2012
Eric Seidel <eric at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 105863: Move pointer to Document up from SelectorChecker to StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=105863
Attachment 180945: Patch
https://bugs.webkit.org/attachment.cgi?id=180945&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180945&action=review
Looks reasonable.
> Source/WebCore/css/SelectorChecker.h:104
> + bool checkScrollbarPseudoClass(Document*, CSSSelector*) const;
Does this method belong on SelectorChecker? It seems odd to be the only method
which takes a Document pointer.
More information about the webkit-reviews
mailing list