[webkit-reviews] review denied: [Bug 105822] Web Inspector: [Canvas] add an option to reload the page if there is an uninstrumented canvas : [Attachment 180868] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 105822: Web Inspector: [Canvas] add an option to reload the page if there
is an uninstrumented canvas
https://bugs.webkit.org/show_bug.cgi?id=105822

Attachment 180868: Patch
https://bugs.webkit.org/attachment.cgi?id=180868&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180868&action=review


> Source/WebCore/inspector/front-end/CanvasProfileView.js:205
> +    this._decorationElement.style.display = "none";

"hidden" style class would do that for you.

> Source/WebCore/inspector/front-end/CanvasProfileView.js:209
> +    reloadPageButton.textContent = "Reload";

This should be localized

> Source/WebCore/inspector/front-end/CanvasProfileView.js:298
> +	       this._decorationElement.style.display = showWarning ? "" :
"none";

ditto