[webkit-reviews] review denied: [Bug 105856] Web Inspector: Workspace should support several projects and should not have temporary UISourceCodes. : [Attachment 180933] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 29 04:32:20 PST 2012


Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 105856: Web Inspector: Workspace should support several projects and should
not have temporary UISourceCodes.
https://bugs.webkit.org/show_bug.cgi?id=105856

Attachment 180933: Patch
https://bugs.webkit.org/attachment.cgi?id=180933&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180933&action=review


> Source/WebCore/inspector/front-end/BreakpointManager.js:239
> +		       this._breakpoints.remove(breakpoint);

This might be a bit more expensive than maintaining buckets for breakpoints.


More information about the webkit-reviews mailing list