[webkit-reviews] review granted: [Bug 105797] Web Inspector: refactor DefaultTextEditor's private methods : [Attachment 180802] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 105797: Web Inspector: refactor DefaultTextEditor's private methods
https://bugs.webkit.org/show_bug.cgi?id=105797

Attachment 180802: Patch
https://bugs.webkit.org/attachment.cgi?id=180802&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180802&action=review


> Source/WebCore/inspector/front-end/DefaultTextEditor.js:437
> +	       this._mainPanel.contextMenu(event.target, contextMenu);

populateContextMenu

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:462
> +	   return this._mainPanel.getSelection();

selection()

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:-484
> -	   return this._mainPanel._lastSelection;

lastSelection

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:556
> +	   this._boundSelectionChangeListener =
this._mainPanel.handleSelectionChange.bind(this._mainPanel);

You should register this listener within mainPanel's wasShown instead.

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:806
> +	   throw new Error("createNewChunk() is not implemented");

... should be implemented by descendants