[webkit-reviews] review granted: [Bug 92818] REGRESSION: WebKit does not render selection in non-first ruby text nodes. : [Attachment 179203] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 27 12:39:06 PST 2012


Levi Weintraub <leviw at chromium.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 92818: REGRESSION: WebKit does not render selection in non-first ruby text
nodes.
https://bugs.webkit.org/show_bug.cgi?id=92818

Attachment 179203: Patch
https://bugs.webkit.org/attachment.cgi?id=179203&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179203&action=review


> Source/WebCore/ChangeLog:11
> +	   it doesn't lay down its children in block direction.

Lay down == lay out?

> Source/WebCore/ChangeLog:30
> +	   http://trac.webkit.org/changeset/12986 but all tests added by this
change set as well as the rest
> +	   of layout tests pass without this condition.

Sadness :(


More information about the webkit-reviews mailing list