[webkit-reviews] review granted: [Bug 105602] [EFL][WebGL] Implement EGL support with GLX : [Attachment 180772] patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Kalyan
<kalyan.kondapally at intel.com>'s request for review:
Bug 105602: [EFL][WebGL] Implement EGL support with GLX
https://bugs.webkit.org/show_bug.cgi?id=105602

Attachment 180772: patch
https://bugs.webkit.org/attachment.cgi?id=180772&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180772&action=review


> Source/WebCore/platform/graphics/surfaces/egl/EGLConfigHelper.cpp:166
> +    EGLConfig rightConfig = 0;

what is a right config? a correct one? why not just config?

> Source/WebCore/platform/graphics/surfaces/egl/EGLContext.cpp:96
> +	   LOG_ERROR("Failed to set EGL API(%d).\n", eglGetError());

Are you sure \n is needed here?

> Source/WebCore/platform/graphics/surfaces/egl/EGLContext.cpp:108
> +    EGLConfig config = surface->configuration();
> +    if (!config)
> +	   return false;
> +
> +    if (config) {

That config check seems useless, as you check above