[webkit-reviews] review denied: [Bug 105787] [Qt][EFL][GTK][TexMap] Refactor code related to debug border and repaint count. : [Attachment 180785] Patch : [TexMap] Refactor code related to debug border and repaint count. [2/2]

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 105787: [Qt][EFL][GTK][TexMap] Refactor code related to debug border and
repaint count.
https://bugs.webkit.org/show_bug.cgi?id=105787

Attachment 180785: Patch : [TexMap] Refactor code related to debug border and
repaint count. [2/2]
https://bugs.webkit.org/attachment.cgi?id=180785&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180785&action=review


This is actually a big change to how we use repaint counters, which would make
them slow and unusable since we draw text and upload it for every paint even if
there is no update.

> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:402
> +    updateDebugBorderAndRepaintCount();

This is wrong :)
repaint counter should be updated when the backing store is actually updated,
not when the layer is flushed.