[webkit-reviews] review granted: [Bug 105800] Web Inspector: Native Memory Instrumentation. Update clang plugin according to current instrumentation state. : [Attachment 180798] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 27 06:52:26 PST 2012
Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 105800: Web Inspector: Native Memory Instrumentation. Update clang plugin
according to current instrumentation state.
https://bugs.webkit.org/show_bug.cgi?id=105800
Attachment 180798: Patch
https://bugs.webkit.org/attachment.cgi?id=180798&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180798&action=review
> Tools/clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:201
> + " info.addRawBuffer(m_pointer, m_length);\n"
You should also add m_length field.
More information about the webkit-reviews
mailing list