[webkit-reviews] review granted: [Bug 105721] Web Inspector: [Canvas] report if there is any uninstrumented canvas on a page : [Attachment 180705] Added a test

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 105721: Web Inspector: [Canvas] report if there is any uninstrumented
canvas on a page
https://bugs.webkit.org/show_bug.cgi?id=105721

Attachment 180705: Added a test
https://bugs.webkit.org/attachment.cgi?id=180705&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180705&action=review


> Source/WebCore/inspector/InspectorCanvasAgent.cpp:118
> +    ensureHasUninstrumentedCanvasesCalculated();

You don't need this call as you check if the agent is enabled and enable method
finds all uninstrumented canvases.

> Source/WebCore/inspector/InspectorCanvasAgent.h:101
> +    FrameToHasUninstrumentedCanvasesResult
m_hasUninstrumentedCanvasesResults;

This can be a set FramesWithUninstrumentedCanvases.