[webkit-reviews] review requested: [Bug 103468] [EFL][WK2] Regression(135935) layout tests snapshots are flaky : [Attachment 180744] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <christophe.dumez at intel.com> has asked  for review:
Bug 103468: [EFL][WK2] Regression(135935) layout tests snapshots are flaky
https://bugs.webkit.org/show_bug.cgi?id=103468

Attachment 180744: Patch
https://bugs.webkit.org/attachment.cgi?id=180744&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Yoohoo :) Merry Christmas everyone!

It took a while but I have finally found the cause of the flakiness in our ref
tests:
- We process repaint requests in the event loop in EwkViewImpl. Therefore, the
view may have pending repaint requests when we are taking the snapshot for ref
/ pixel tests.
My patch makes sure pending repaint requests are processed because taking the
snapshot. I can no longer reproduce the flakiness after this.

Note that 2 of the tests previously marked as flaky are now consistently
failing due to the text being blurry when scaled. I filed Bug 105766 for that.
I remember we had this bug in the past but I thought this was fixed already.
Someone may want to investigate.