[webkit-reviews] review denied: [Bug 105752] Move visited link-checking (and caching) code out of SelectorChecker. : [Attachment 180726] Moved cache to document.

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 105752: Move visited link-checking (and caching) code out of
SelectorChecker.
https://bugs.webkit.org/show_bug.cgi?id=105752

Attachment 180726: Moved cache to document.
https://bugs.webkit.org/attachment.cgi?id=180726&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=180726&action=review


This doesn't seem like a progression to me. The code get spread out and the
already bloaty Document grows further.

 Why not factor this into a type? LinkStyleInvalidator or similar.

> Source/WebCore/html/HTMLAnchorElement.h:107
> +    static EInsideLink determineLinkState(Element*);
> +    static LinkHash linkHashForElement(Element*);

Hanging generic Element functions to HTMLAnchorElement is confusing.