[webkit-reviews] review granted: [Bug 104990] Coordinated Graphics: Manage the lifecycle of CoordinatedGraphicsLayer explicitly. : [Attachment 180719] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 25 16:49:59 PST 2012


Noam Rosenthal <noam at webkit.org> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 104990: Coordinated Graphics: Manage the lifecycle of
CoordinatedGraphicsLayer explicitly.
https://bugs.webkit.org/show_bug.cgi?id=104990

Attachment 180719: Patch
https://bugs.webkit.org/attachment.cgi?id=180719&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180719&action=review


LGTM, but let's rename to getLayerByIDIfExists

> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:351
> +GraphicsLayer* LayerTreeRenderer::layerByIDIfPossible(CoordinatedLayerID id)


getLayerByIDIfExists


More information about the webkit-reviews mailing list