[webkit-reviews] review granted: [Bug 105722] Web Inspector: Make InspectorState instances per-agent, corresponding to JSON map entries in the cookie : [Attachment 180703] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 24 23:35:57 PST 2012


Yury Semikhatsky <yurys at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 105722: Web Inspector: Make InspectorState instances per-agent,
corresponding to JSON map entries in the cookie
https://bugs.webkit.org/show_bug.cgi?id=105722

Attachment 180703: Patch
https://bugs.webkit.org/attachment.cgi?id=180703&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180703&action=review


> Source/WebCore/inspector/InspectorState.cpp:137
> +	   if (!agentStateObject) {

When can this happen? Also if some agent states may be missing there might be
some extra states which we probably want to delete?


More information about the webkit-reviews mailing list